Block Library: Move translatable fields to block.json files
#31120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gziolo
changed the base branch from
trunk
to
add/register-block-type-from-metadata
7 tasks
gziolo
added
Internationalization (i18n)
gziolo
changed the title
block.json files
gziolo
changed the title
block.json filesblock.json files
|
Size Change: -98 B (0%) Total Size: 1.31 MB
ℹ️ View Unchanged
|
gziolo
force-pushed
the
update/block-json-i18n-fields
branch
3 times, most recently
from
1fa873a to
ccf20e6
Compare
gziolo
force-pushed
the
add/register-block-type-from-metadata
branch
from
b851c2f to
f371ba8
Compare
gziolo
force-pushed
the
update/block-json-i18n-fields
branch
3 times, most recently
from
34fbc94 to
a0b20e7
Compare
|
I don't recall it appearing specifically in the Calls for testing, which haven't focused on those blocks until the 5th round with the Query testing, but improving theme block descriptions came up during the Go/no-go demo, which was in a way FSE testing. For example, the Site Logo description was updated in #30909 |
gziolo
force-pushed
the
update/block-json-i18n-fields
branch
from
a0b20e7 to
c6864a3
Compare
|
Can confirm that this has not come up in calls for testing! |
gziolo
force-pushed
the
update/block-json-i18n-fields
branch
2 times, most recently
from
035e8e8 to
e433b8a
Compare
gziolo
requested review from
ajitbohra,
ajlende,
mkaz and
mkevins
as code owners
gwwar
approved these changes
Apr 26, 2021
There was a problem hiding this comment.
So for folks running Gutenberg plugin with WP 5.7, is it correct that all block library translations will not be applied until translations are updated for WP 5.8?
For folks reviewing 👀 I double checked the text domain values:
Core Blocks use "default" as expected:
And when this is injected in the page via wp.i18n.setLocaleData( localeData, domain ), domain is also set to "default" even if translation data confusingly has this set to "messages"
gziolo
force-pushed
the
update/block-json-i18n-fields
branch
from
ac7e19e to
9375beb
Compare
|
I tested the native version and I saw that the only property that uses the localized value is You can check in the Gutenberg-mobile repo the localization files that we use in the mobile app: |
gziolo
force-pushed
the
update/block-json-i18n-fields
branch
from
9375beb to
58ea038
Compare
gziolo
force-pushed
the
update/block-json-i18n-fields
branch
from
58ea038 to
7811af5
Compare
Heads up that this statement from "How has this been tested?" is not being totally fulfilled, as per my previous comment, the only translation that is being applied is the one for the block's title, the rest are using the English value. I'm not sure about the impact of not having the rest of the settings localized, my impression is that it would be low as I haven't found any missing translation (apart from the ones that we already have identified) after testing this PR. However, this would be a major issue once we release the search feature in the inserter menu because it relies on the localized values of the block's settings like cc @jhnstn |
We use a consistent way of applying a context to all translations related to block types. It means that many translations need to be added processed again. It's going to happen as part of the major WordPress release process, that starts on May 25th. We will have to confirm everything goes smoothly for WordPress core, Gutenberg plugin and the mobile app. |
Ok, thanks @gziolo for the info, we'll be looking forward to this 👀 . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Depends on #30293.
Fixes #23792.
Part of #16209.
All 77 blocks were updated. Fields that are wrapped with i18n helpers were moved from
registerBlockTypecall toblock.jsonfiles.Translatable fields sourced from
block.jsonhave automatically applied a translation context which mostly weren't present before. This means that many translations are missing for the time being. It should get resolved during the release cycle of WordPress 5.8.How has this been tested?
All translatable fields for blocks should have their translations applied on the server when testing with WordPress.
When testing with the mobile app, all translations should still get applied as before on the client.
Screenshots
No visual changes.
Types of changes
Code quality.
Checklist:
*.native.jsfiles for terms that need renaming or removal).